----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review80870 -----------------------------------------------------------
include/mesos/scheduler/scheduler.proto <https://reviews.apache.org/r/32845/#comment131014> Is UNSUBSCRIBE the right name for this? It seems like "unsubscribe" would stop the subscription for events, rather than shutdown all the tasks and remove the framework. That seems prone to a bit of confusion and mistakes? For example, would an operator remove a framework with an /unsubscribe endpoint? Hm.. it seems like SHUTDOWN would have been the best names for this? Should we re-use KILL for executors, but use SHUTDOWN for frameworks? - Ben Mahler On April 20, 2015, 8:04 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32845/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 8:04 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > Renamed UNREGISTER call to UNSUBSCRIBE for consistency. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc > src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32845/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
