> On April 8, 2015, 9:57 p.m., Vinod Kone wrote: > > src/launcher/fetcher.cpp, line 332 > > <https://reviews.apache.org/r/32975/diff/1/?file=920879#file920879line332> > > > > and chown is requested.
done > On April 8, 2015, 9:57 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 208 > > <https://reviews.apache.org/r/32975/diff/1/?file=920878#file920878line208> > > > > please update type_utils.cpp to account for this field when comparing > > CommandInfos. done > On April 8, 2015, 9:57 p.m., Vinod Kone wrote: > > src/tests/fetcher_tests.cpp, lines 112-116 > > <https://reviews.apache.org/r/32975/diff/1/?file=920880#file920880line112> > > > > Add a note/todo here mentioning why you are setting these fields but > > not doing any asserts/expects on them. With the type_utils.cpp change, the EXPECT_EQ on lines 140/141 should be checking the chown field. Should I still add text regarding how we can't check this capability without assuming the user running the test has permission to chown to some other user? - Jim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32975/#review79433 ----------------------------------------------------------- On April 8, 2015, 2:20 p.m., Jim Klucar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32975/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 2:20 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1790 > https://issues.apache.org/jira/browse/MESOS-1790 > > > Repository: mesos > > > Description > ------- > > Added chown to CommandInfo.URI protocol buffer as an optional > boolean that defaults to true, the current chown behavior. > > The fetcher was updated to skip the os::chown operation if the chown > boolean is set to false. > > No documentation was updated. > > > Diffs > ----- > > include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 > src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25 > src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e > > Diff: https://reviews.apache.org/r/32975/diff/ > > > Testing > ------- > > Unit testing this functionality is difficult because it would require that > the user running the test to have permission to chown a file to someone other > than themselves. I didn't want to add that as a requirement to build. I added > the new field to the existing test cases just to see that they populate. > > > Thanks, > > Jim Klucar > >
