Latest diff on review site looks to have all the fixes. I'm probably not using the review site correctly (closing issues before I upload a diff?) but still the code that's up there matches what I have locally.
On Mon, Apr 20, 2015 at 10:20 PM, Adam B <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32975/ > > On April 13th, 2015, 10:20 a.m. PDT, *Vinod Kone* wrote: > > src/tests/fetcher_tests.cpp > <https://reviews.apache.org/r/32975/diff/3/?file=925449#file925449line708> > (Diff > revision 3) > > 708 > > // First construct a temporary file that can be fetched and archive > > s/archive/archived/ ? > > On April 13th, 2015, 2:17 p.m. PDT, *Jim Klucar* wrote: > > fixed as suggested > > Jim, you claim that you've fixed these issues, but I don't see an updated > diff with those changes. Please update. > > > - Adam > > On April 13th, 2015, 9:55 a.m. PDT, Jim Klucar wrote: > Review request for mesos. > By Jim Klucar. > > *Updated April 13, 2015, 9:55 a.m.* > *Bugs: * MESOS-1790 <https://issues.apache.org/jira/browse/MESOS-1790> > *Repository: * mesos > Description > > Added chown to CommandInfo.URI protocol buffer as an optional > boolean that defaults to true, the current chown behavior. > > The fetcher was updated to skip the os::chown operation if the chown > boolean is set to false. > > No documentation was updated. > > Testing > > Unit testing this functionality is difficult because it would require that > the user running the test to have permission to chown a file to someone other > than themselves. I didn't want to add that as a requirement to build. I added > the new field to the existing test cases just to see that they populate. > > Diffs > > - include/mesos/mesos.proto (3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8) > - src/common/type_utils.cpp (e92f6f36de0955784619029a016667b46bbe221b) > - src/launcher/fetcher.cpp (796526f59c25898ef6db2b828b0e2bb7b172ba25) > - src/tests/fetcher_tests.cpp > (4549e6a631e2c17cec3766efaa556593eeac9a1e) > > View Diff <https://reviews.apache.org/r/32975/diff/> >
