> On April 11, 2015, 3:54 a.m., Adam B wrote: > > src/tests/hook_tests.cpp, lines 132-140 > > <https://reviews.apache.org/r/31028/diff/4/?file=920383#file920383line132> > > > > Why this change? What's wrong with the TestContainerizer?
I was running into issues as the test containerizer doesn't support using the command executor. Let me double check real quick if this is a moot change compared to the test refactor later in this patch set. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review79804 ----------------------------------------------------------- On April 11, 2015, 3:03 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31028/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 3:03 a.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/31028/diff/ > > > Testing > ------- > > make check (with newly added VerifySlaveRunTaskHook test) > > > Thanks, > > Niklas Nielsen > >
