----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review80822 -----------------------------------------------------------
Ship it! Looks great! src/tests/hook_tests.cpp <https://reviews.apache.org/r/31028/#comment130932> Would be great to see a diagram of these labels coming and going at different points in the runTask lifecycle. It's a little confusing keeping track of what happens when. New documentation JIRA? - Adam B On April 20, 2015, 1:17 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31028/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 1:17 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/examples/test_hook_module.cpp 2f2da1c5ef85af06c7f366d38ce5b64f39d0076f > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/31028/diff/ > > > Testing > ------- > > make check (with newly added VerifySlaveRunTaskHook test) > > > Thanks, > > Niklas Nielsen > >
