Thank you haosdent, I did not notice that the bug was already fixed. I have opened the Jira https://issues.apache.org/jira/browse/MESOS-5101 and submitted a updated a different patch file to the review board.
On 3 April 2016 at 18:08, haosdent <haosd...@gmail.com> wrote: > Hi, I think your build failure have already resolved by @Joerg > https://reviews.apache.org/r/45582/ > > Could you rebase it and fill a ticket for your docker_build.sh update in > https://issues.apache.org/jira/browse/MESOS? > > On Sun, Apr 3, 2016 at 11:45 PM, Juan Larriba <jlarr...@gmail.com> wrote: > > > I have created the review https://reviews.apache.org/r/45656/ that > solves > > the problem with CMake build in Linux (it was failing) and updates > > docker_build.sh to support CMake build. I have enabled the CMake build > as a > > new compiler option, so it can be built alongside GCC and clang. > > > > Please notice that for CMake builds, the ENVIRONMENT env variable is not > > used, so it does not need to be set. The CONFIGURE variable must be, at > > least: > > > > export CONFIGURE='-G "Unix Makefiles"' > > > > and accepts also the parameter -DENABLE_LIBEVENT:BOOL="1" if libevent > wants > > to be used instead of libev, > > > > The COMPILER variable must be "cmake". > > > > Also, the CMake compilation does not need to perform the ./bootstrap > > action. > > > > It has been tested in ubuntu:14.04 and centos:7. > > > > On 29 March 2016 at 08:44, Juan Larriba <jlarr...@gmail.com> wrote: > > > > > CMake build currently fails on Linux, so I am working on fixing the > Agent > > > build before sending the review for the modified docker_build.sh > > > > > > On 27 March 2016 at 09:39, Juan Larriba <jlarr...@gmail.com> wrote: > > > > > >> OK Vinod, I will work on it. > > >> > > >> On 26 March 2016 at 20:45, Vinod Kone <vinodk...@apache.org> wrote: > > >> > > >>> On Sat, Mar 26, 2016 at 3:12 AM, Juan Larriba <jlarr...@gmail.com> > > >>> wrote: > > >>> > > >>> > For your advice on contribution, both tasks you have stated sound > > >>> great to > > >>> > me, and adapting the CI system for CMake build sounds great. If you > > can > > >>> > point me to the CI server the project is using for the builds (as I > > >>> don't > > >>> > manage to find it by myself), I can clone the setting in my local > > test > > >>> > environment to begin doing tests on CMake builds, identify the > needed > > >>> > changes and ask for integrate them on the CI server. > > >>> > > > >>> > > >>> > > >>> I'm happy to help enable CMake for Linux on ASF CI > > >>> <https://builds.apache.org/view/M-R/view/Mesos/>. If you or Alex can > > >>> update > > >>> "support/docker_build.sh" and send a review, I'll merge it upstream. > > >>> > > >> > > >> > > > > > > > > > -- > Best Regards, > Haosdent Huang >
