Hey folks. Microsoft is putting on their annual developer conference, "//build", next week, so I don't have time to respond in detail, but I did want to address the immediate questions of the .patch file and contributing.
For contributing at the state of the art, the two most valuable things you can do are (1) help with code reviews, or (2) help change the CI system to build and test from CMake on both Windows and Linux. Writing new code is not the bottleneck at this point -- we have a feature branch with a working agent, and a finite number of commits (less than 100) that need to be reviewed and checked in. The big obstacles are that the Windows build is consistently inadvertently broken because there is no CI integration, and the fact that I personally have to review every Windows patch that comes through. If you want to help with these, I am happy to direct you on how to proceed. To your question about the .patch file, this sounds like a bug. Can you please tell me the SHA of your head, and also check that the file has CRLF line endings in your local repository? We are building out of VisualStudio, by the way, but I don't expect that to make a difference. If this is a line ending issue we may need to add a .gitattributes entry to make an exception for the patch files. On Fri, Mar 25, 2016 at 4:48 PM, Juan Larriba <jlarr...@gmail.com> wrote: > Thank you Tommy and Benjamin, it would be very nice if someone could update > with any news. > > However, I continued trying to build and, after unload the stout_tests > project, I am stuck building the Zookeeper dependency. > > CMake is trying to patch zookeeper-06d3f3f (using that version as 3.4.5 does > not compile in Windows) using GnuWin32 patch.exe, but I am receiving the > traditional error: > > Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354 > > Which means that we are trying to patch a file with Unix line end (LF) > instead of DOS line end (CR-LF). Normally, this is solved using the --binary > option during patching, but if I enable it in the CMake configuration, it > fails to patch the vcxproj file: > > patching file src/c/zookeeper.vcxproj > 2> Hunk #1 FAILED at 1. > 2> Hunk #2 FAILED at 22. > 2> Hunk #3 FAILED at 81. > 2> Hunk #4 FAILED at 105. > 2> Hunk #5 FAILED at 125. > 2> Hunk #6 FAILED at 145. > 2> 6 out of 6 hunks FAILED -- saving rejects to file > src/c/zookeeper.vcxproj.rej > 2> patching file src/c/zookeeper-vs2015.sln > 2> patching file src/c/include/winconfig.h > 2> patching file src/c/include/winstdint.h > > Any kind of advice would be nice. > > Thank you very much. > > On 25 March 2016 at 23:36, Benjamin Mahler <bmah...@apache.org> wrote: >> >> + Alex Clemmer >> >> On Thu, Mar 24, 2016 at 7:50 PM, tommy xiao <xia...@gmail.com> wrote: >> >> > i remember microsoft team invovled in this case, but not found any >> > update >> > on it? anyone can update news? >> > >> > 2016-03-25 6:08 GMT+08:00 Juan Larriba <jlarr...@gmail.com>: >> > >> > > Hi all, >> > > >> > > I have been working with Mesos for the past months and I am very >> > interested >> > > in its possibilities and the capabilities it offers. >> > > >> > > Until now, I have been working with Mesos on Linux, and it works as a >> > > charm, but I was interested in joining Windows based systems to the >> > > clusters, and the possibilities it offer. >> > > >> > > When I searched for that possibility, I discovered that a functional >> > > demo >> > > had been done in August 2015 ( >> > > >> > > >> > >> > https://mesosphere.com/blog/2015/08/20/mesos-everywhere-apache-mesos-for-windows-server/ >> > > ) >> > > and I reached a question in StackOverflow ( >> > > >> > > >> > >> > http://stackoverflow.com/questions/33700919/roadmap-for-apache-mesos-on-windows >> > > ) >> > > where they point out the Jira tickets that are being used to monitor >> > > the >> > > development progress. >> > > >> > > The StackOverflow answer even goes further and says that as of >> > > November >> > > 2015, the CMake-based build was pretty functional, even generating an >> > agent >> > > binary. >> > > >> > > So I downloaded the source and went into building Mesos on Windows >> > > using >> > > Visual Studio 2015, but I ended with some compilation errors and no >> > binary >> > > agent being generated. I would love to help in this task to my >> > > possibilities extents, but the truth is there is no documentation for >> > > Windows CMake build. >> > > >> > > After searching for two weeks without clue on how to continue, I >> > > decided >> > to >> > > write to the list with my issues, hoping someone could help me. My >> > > idea >> > is >> > > to contribute to the Windows port to the extent of my possibilities >> > > once >> > I >> > > have figured out the real state of the art. >> > > >> > > Currently, after configuring CMake with ENABLE_LIBEVENT=1, >> > > REBUNDLED=1, >> > > AGENT_TARGET=mesos-slave, 3RDPARTY_DEPENDENCIES=<local directory with >> > > the >> > > contents of https://github.com/3rdparty/mesos-3rdparty> and Visual >> > Studio >> > > 14 2015 Win64 as generator, it correctly generated a Mesos.sln. >> > > >> > > Then, I try to build Mesos.sln with: >> > > >> > > msbuild.exe Mesos.sln /t:Build /p:Configuration=Release;Platform=x64 >> > > >> > > And, after a while, it ends with two errors: >> > > >> > > error C2039: 'mknod': is not a member of 'os' >> > > error C2039: 'rdev': is not a member of 'os::stat'. >> > > >> > > Both are on Project stout_tests (rmdir_tests.cpp). >> > > >> > > The point is looking at the code, it is true that both functions are >> > > not >> > > there, so I am a bit confused. >> > > >> > > I imagine that, as the port to Windows is not yet finished, the build >> > will >> > > not pass the tests, but I am unable to figure out what to do next, and >> > > I >> > > would appreciate some advice on how to build the current version of >> > > the >> > > Agent. >> > > >> > > Thank you very much. >> > > >> > >> > >> > >> > -- >> > Deshi Xiao >> > Twitter: xds2000 >> > E-mail: xiaods(AT)gmail.com >> > > > -- Alex Theory is the first term in the Taylor series of practice. -- Thomas M Cover (1992)
