Github user jieyu commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/263#discussion_r168652041
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -721,7 +721,7 @@ Future<Option<ContainerLaunchInfo>> 
NetworkCniIsolatorProcess::prepare(
         env->set_name("LIBPROCESS_IP");
         env->set_value("0.0.0.0");
     
    -    if (!containerId.has_parent()) {
    +    if (needsSeparateNs) {
    --- End diff --
    
    This should be
    ```
    if (!isDebugContainer && (!nestedContainer || !joinParentNetwork))
    ```


---

Reply via email to