Github user jieyu commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/263#discussion_r168654738
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -820,18 +821,16 @@ Future<Nothing> NetworkCniIsolatorProcess::isolate(
       CHECK_SOME(rootDir);
       CHECK_SOME(pluginDir);
     
    -  if (containerId.has_parent()) {
    +  if (!infos[containerId]->needsSeparateNs) {
    --- End diff --
    
    I'd make this more explicit.
    ```
    // NOTE: DEBUG container should not have Info struct. Thus if the control
    // reaches here, the container is not a DEBUG container.
    if (isNestedContainer && joinParentNetwork)
    ```


---

Reply via email to