Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/279#discussion_r179547033
--- Diff: src/master/master.cpp ---
@@ -6843,6 +6846,17 @@ void Master::__reregisterSlave(
recoveredTasks.push_back(std::move(task));
}
+ foreachkey(FrameworkID frameworkId, frameworkToTasks) {
--- End diff --
Can we just reference entries from `slaves.unreachableTasks` directly? Also
if some items in `framework-> unreachableTasks` are already removed during
recovering tasks above, they'll just be noops here.
---