Github user xujyan commented on a diff in the pull request:
https://github.com/apache/mesos/pull/279#discussion_r179546249
--- Diff: src/master/master.cpp ---
@@ -6805,6 +6807,7 @@ void Master::__reregisterSlave(
Framework* framework = getFramework(frameworkId);
if (framework != nullptr) {
framework->unreachableTasks.erase(task.task_id());
+ frameworkToTasks[frameworkId].erase(task.task_id());
--- End diff --
I see why you are doing this but I feel it is making things a bit more
complex than necessary.
Overall we are just removing tasks from `framework.unreachableTasks` from
two sources, can we just separate the two? You already have the code below that
does that. See comment below.
---
