> On Jul 8, 2018, at 10:55 PM, Benjamin Bannier
> <benjamin.bann...@mesosphere.io> wrote:
>
> Hi James,
>
>> I’d like to propose that we update our style to require that the
>> “override” keyword always be used when overriding virtual functions
>> (including destructors). The proposed text is below. I’ll also prepare
>> a clang-tidy patch to update stout, libprocess and mesos globally.
>
> +1!
>
> Thanks for bringing this up and offering to do the clean-up. Using `override`
> consistently would really give us some certainty as interface methods evolve.
>
> * * *
>
> Note that since our style guide _is_ the Google style guide plus some
> additions, we shouldn't need to update anything in our style guide; the Google
> style guide seems to have started requiring this from February this year and
> our code base just got out of sync
I'd prefer to hoist the rationale up to our guide, since the google one is
pretty long and I don't expect us to all re-read it regularly :)
I'll definitely make the tooling changes you suggest (look for a review request
in the near future)
J
