Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/20#issuecomment-96819800
My 5 cents:
* I like the approach you've taken here with the compound from items array.
* But shouldn't we rather then take a step further and delete the
"leftItem" and "rightItem" and let the array replace them.
* Similarly I would expect an array for the "on items" then. And then
delete the "leftOn" and "rightOn" fields.
* Then you would no longer need "_isCompoundJoin" - it would always be a
(compound) join if there is an array available.
Alternative approach is to keep FromItem as it is and just apply the nested
FromItem structure when parsing the query. That would retain 100% backwards
compatibility and only do something in the query parsing layer to fix the
issue. Might also be an option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
