Github user narahari92 commented on the pull request:
https://github.com/apache/metamodel/pull/20#issuecomment-96911117
Hi,
I looked into the points you mentioned above. Below are my thoughts.
1. We actually need "leftItem" and "rightItem" as we even use it in
compound from items ultimately, since it's the only way to represent join.
2. "on items" are indeed array of select items and for each from item we
need them seperately since there might be other operations than "=".
3. I didn't try about nested from items but it needs code change more than
this. Moreover with this approach we are using existing code which is both unit
tested and time tested.
4. This doesn't cause any api changes either as there is no change in
signature of any public method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
