GitHub user LosD opened a pull request:

    https://github.com/apache/metamodel/pull/49

    Use File instead of InputStream for Excel when possible

    The memory usage by Apache POI is quite a bit lower when using File instead 
of InputStream. This makes sure that FileResource's internal File object will 
be passed object to POI.
    
    POI has some problems with saving to an already opened file, so a temp file 
is used for saving.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LosD/metamodel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit 053c34684f6f46948bc3ad3a71a5a366ac9526f8
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-03T13:41:44Z

    Use missing and exists filters for null comparisons.
    
    This will make isNull() and isNotNull() work. They failed before, as a
     term query, which does not support null values, was used. A test was
      also un-ignored; It was ignored as it used to fail, but the fix
      for METAMODEL-172 fixed the test as well.

commit d22f299956bc8ef9752b0cee920b1d5594e4b693
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-03T14:07:59Z

    Improves exception handling

commit 9221755629d258c069f45ecda98f53399df08781
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-08T12:33:10Z

    An attempt to lower memory usage of Excel
    
    This is currently not properly functioning (creating fails)

commit 79d222009570a725ede6b5293b5096d3839188f3
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-09T08:46:51Z

    Use tempfile when writing resource to keep POI happy
    
    This seems to actually make my approach work properly.

commit 250fd691032bcd2d1505f312682a3b99cf3570f7
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-09T09:02:15Z

    Merge remote-tracking branch 'origin/master'

commit ca65aab89657c22e2d15b09c94dbbadaa199e640
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-09T09:07:47Z

    Removes memory test

commit 517e22c0d5e25e5fcf703595824297d0cf364de3
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-09T09:10:14Z

    Merge branch 'feature/excel-memory-experiment'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to