Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41100980
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java ---
@@ -78,7 +87,24 @@ public ExcelDataContext getDataContext() {
protected void close() {
if (_workbook != null) {
- ExcelUtils.writeWorkbook(_dataContext, _workbook);
+
+ final Resource resource;
+ if(_dataContext.getResource() instanceof FileResource){
--- End diff --
Trying to find what the issue might be ... And this if-sentence is making
me wonder: Why is it here, and if it is supposed to write non-file resources to
a temp-file, isn't it all wrong then? Shouldn't it be "if resources is NOT a
FileResource"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
