----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46902/#review131361 -----------------------------------------------------------
Looks good to me, but see a single comment. full/src/main/java/org/apache/metamodel/DataContextFactory.java (line 765) <https://reviews.apache.org/r/46902/#comment195292> Shouldn't that be a "List<TableDataProvider<?>> tables" as parameter? - Tomasz Guzialek On May 2, 2016, 7:33 p.m., Sagar Gandhi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46902/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 7:33 p.m.) > > > Review request for MetaModel. > > > Repository: metamodel > > > Description > ------- > > Bug Description : > Every DataContext implementation is represented in the DataContextFactory > with a method for creating such DataContext. However, there are no methods > for creating HBaseDataContext and PojoDataContext. > > Solution : > Created methods for HBase and Pojo. Added different overloaded methods for > overloaded constructors. > > > Diffs > ----- > > full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2 > > Diff: https://reviews.apache.org/r/46902/diff/ > > > Testing > ------- > > > Thanks, > > Sagar Gandhi > >
