Hi Sagar, Now a committer needs to take the patch and apply it on master. I will take it from here. Thanks for your contribution!
Pozdrawiam / Regards / Med venlig hilsen Tomasz Guziałek 2016-05-02 22:16 GMT+02:00 Sagar Gandhi <[email protected]>: > Hi Tomasz, > > can you please guide me how to proceed for check-in ? . I am not a > committer, what are the steps I need to perform to help committer check-in > this patch ? > > > Thanks , > Mr.Sagar Gandhi, > Pune. > (+91)9028440503 > > > > Subject: Re: Review Request 46902: METAMODEL-159 : DataContextFactory > misses methods to create HBase and POJO data contexts > > From: [email protected] > > To: [email protected]; [email protected]; > [email protected] > > Date: Mon, 2 May 2016 20:13:37 +0000 > > > > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/46902/ > > ----------------------------------------------------------- > > > > (Updated May 2, 2016, 8:13 p.m.) > > > > > > Review request for MetaModel. > > > > > > Changes > > ------- > > > > Technical error viewing diff 3 > > > > > > Repository: metamodel > > > > > > Description > > ------- > > > > Bug Description : > > Every DataContext implementation is represented in the > DataContextFactory with a method for creating such DataContext. However, > there are no methods for creating HBaseDataContext and PojoDataContext. > > > > Solution : > > Created methods for HBase and Pojo. Added different overloaded methods > for overloaded constructors. > > > > > > Diffs (updated) > > ----- > > > > full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2 > > > > Diff: https://reviews.apache.org/r/46902/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Sagar Gandhi > > >
