Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/107#discussion_r65733579
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcMetadataLoader.java ---
@@ -92,20 +91,27 @@ public void loadTables(JdbcSchema schema, Connection
connection) {
}
}
+ private String getSchemaName(Schema schema) {
--- End diff --
This method name here can be a bit confusing because there is both a
concept of "schema" in JDBC and in MetaModel. And the unfortunate thing is that
they aren't 100% aligned, which is basically what the _usesCatalogAsSchemas
flag is used to determine.
I would rename it to "getJdbcSchemaName" to avoid that confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
