Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/107#discussion_r65771496
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataSet.java ---
@@ -197,8 +197,12 @@ public void close() {
if (_closed) {
return;
}
+
+ FileHelper.safeClose(_resultSet);
+
if (_jdbcDataContext != null) {
- _jdbcDataContext.close(_connection, _resultSet, _statement);
+ FileHelper.safeClose(_statement);
--- End diff --
No, we can't close the statement unconditionally, it makes almost every
single test fail. I'm not entirely sure why (didn't really pursue it, honestly).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
