Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/165#discussion_r148126992
  
    --- Diff: 
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
    @@ -235,38 +240,28 @@ private boolean isSimpleSelect(SelectClause clause) {
         }
     
         /**
    -     * Executes a simple count query, if possible. This method is provided 
to
    -     * allow subclasses to optimize count queries since they are quite 
common
    -     * and often a datastore can retrieve the count using some specialized 
means
    -     * which is much more performant than counting all records manually.
    +     * Executes a simple count query, if possible. This method is provided 
to allow subclasses to optimize count queries
    +     * since they are quite common and often a datastore can retrieve the 
count using some specialized means which is
    +     * much more performant than counting all records manually.
          * 
    -     * @param table
    -     *            the table on which the count is requested.
    -     * @param whereItems
    -     *            a (sometimes empty) list of WHERE items.
    -     * @param functionApproximationAllowed
    -     *            whether approximation is allowed or not.
    +     * @param table the table on which the count is requested.
    +     * @param whereItems a (sometimes empty) list of WHERE items.
    +     * @param functionApproximationAllowed whether approximation is 
allowed or not.
    --- End diff --
    
    Unrelated change.


---

Reply via email to