Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/165
In the one I looked at (QueryPostProcessessDataContext.java), the actual
changes were around 10-15 lines (a little more with the since-introduced
JavaDoc), out of 175 lines changed total, in a 700 lines class. A quick glance
seems to repeat those numbers for many other classes.
Reformatting is fine.... For the method you're changing, even only for the
lines around if it's a few lines in a larger method (of course those shouldn't
exist... But they do ð) Anything else is just wasting the reviewers time on
trying to find out what is actual changes, as well as making history traversal
an even bigger pain. `?w=1` helps, but not much when lines gets broken up (as
they do most of the time). The noise also makes it easier for problems to slip
through, as it's _so_ easy to miss an actual change in what looks like yet
another reformat.
You can't even look for highlights, as a moved part will also be
highlighted (this is with `?w=1`):
I'll continue, but please don't do that again if you expect people to spend
their spare time reviewing it.
---
