Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/190#discussion_r222489649
  
    --- Diff: 
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUpdateCallback.java ---
    @@ -42,18 +43,35 @@
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    +import com.google.common.cache.CacheBuilder;
    +import com.google.common.cache.CacheLoader;
    +import com.google.common.cache.LoadingCache;
    +import javafx.util.Pair;
    --- End diff --
    
    We should not rely on javafx.


---

Reply via email to