Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/190#discussion_r222489903
  
    --- Diff: 
jdbc/src/test/java/org/apache/metamodel/jdbc/ConnectionWrapper.java ---
    @@ -0,0 +1,286 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.metamodel.jdbc;
    +
    +import java.sql.Array;
    +import java.sql.Blob;
    +import java.sql.CallableStatement;
    +import java.sql.Clob;
    +import java.sql.Connection;
    +import java.sql.DatabaseMetaData;
    +import java.sql.NClob;
    +import java.sql.PreparedStatement;
    +import java.sql.SQLClientInfoException;
    +import java.sql.SQLException;
    +import java.sql.SQLWarning;
    +import java.sql.SQLXML;
    +import java.sql.Savepoint;
    +import java.sql.Statement;
    +import java.sql.Struct;
    +import java.util.Map;
    +import java.util.Properties;
    +import java.util.concurrent.Executor;
    +
    +/** Simple wrapper around Connection */
    --- End diff --
    
    Javadoc convention says that there should be a header and footer line, so 
this should become
    ```
    /**
     * Simple wrapper around Connection
     */
    ```


---

Reply via email to