arjansh commented on a change in pull request #229: Upgrade to Elasticsearch
7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r332376178
##########
File path:
elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
##########
@@ -267,6 +264,10 @@ public static ColumnType
getColumnTypeFromElasticSearchType(final String metaDat
}
public static Row createRow(final Map<String, Object> sourceMap, final
String documentId, final DataSetHeader header) {
+ if (sourceMap == null) {
+ return null;
Review comment:
This is a static helper method which creates a row for a source map and as
such if no source map is passed as an argument it shouldn't return a row. I'll
add a javadoc comment which explains a bit what the method does to make this
clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
