arjansh commented on a change in pull request #229: Upgrade to Elasticsearch
7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r338914203
##########
File path:
elasticsearch/native/src/main/java/org/apache/metamodel/elasticsearch/nativeclient/ElasticSearchDataContextFactory.java
##########
@@ -131,10 +135,16 @@ public DataContext create(DataContextProperties
properties, ResourceFactoryRegis
}
private Client createTransportClient(DataContextProperties properties) {
- final Settings settings = Settings.builder().put().put("name",
"MetaModel").put("cluster.name", getCluster(properties)).build();
+ final Settings settings = Settings
+ .builder()
+ .put("name", "MetaModel")
Review comment:
As you noticed, it was already there and it's part of the "native client",
which is going to be deprecated as part of this Pull Request, so I'd rather not
change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
