Github user kaspersorensen commented on the pull request:
https://github.com/apache/incubator-metamodel/pull/3#issuecomment-57658518
Hi Francisco,
All the changes look solid and good to me. But I am a bit concerned about
all the cosmetic changes to indentation, line-width etc. etc.
To your defense, this is not very well guarded or described. But here's my
"recipe" that has been used in MetaModel:
1) Make a copy of the defaults in eclipse's java code formatter
2) Change line width from 80 chars to 120 chars
3) Change tabs to spaces (4 spaces)
If you can do that and re-format the classes that you've been working on,
then I think we'll have a much prettier diff and thus better be able to track
actual changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
