Hello Kasper, I followed the notes in CONTRIBUTE.md:
-------------------------------------- We stick to the [Google Java Style Guide]( http://google-styleguide.googlecode.com/svn/trunk/javaguide.html), with a few modifications/exceptions: * We often prefix instance variables with an underscore (_). This to easily distinguish between method local and instance variables, as well as avoiding the overuse of the 'this' keyword in e.g. setter methods. * We format indentation using spaces, not tabs. We use 4 spaces for each indentation. * We format line wrapping using a desired max line length of 120 characters. -------------------------------------- I develop on intelliij and before I pushed the changes, I applied the previous format (I configured intellij with the google style xml and I changed indentation space and max line length). What is the right fomat? Regards, 2014-10-02 18:40 GMT+02:00 kaspersorensen <[email protected]>: > Github user kaspersorensen commented on the pull request: > > > https://github.com/apache/incubator-metamodel/pull/3#issuecomment-57658518 > > Hi Francisco, > > All the changes look solid and good to me. But I am a bit concerned > about all the cosmetic changes to indentation, line-width etc. etc. > > To your defense, this is not very well guarded or described. But > here's my "recipe" that has been used in MetaModel: > 1) Make a copy of the defaults in eclipse's java code formatter > 2) Change line width from 80 chars to 120 chars > 3) Change tabs to spaces (4 spaces) > > If you can do that and re-format the classes that you've been working > on, then I think we'll have a much prettier diff and thus better be able to > track actual changes. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- > -- Francisco Javier Cano Senior Developer <http://www.stratio.com/> Avenida de Europa, 26. Ática 5. 3ª Planta 28224 Pozuelo de Alarcón, Madrid Tel: +34 91 352 59 42 // *@stratiobd <https://twitter.com/StratioBD>*
