Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/606#discussion_r119928459
--- Diff:
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/WindowProcessor.java
---
@@ -89,7 +89,7 @@ public void exitIdentifier(WindowParser.IdentifierContext
ctx) {
if(checkForException(ctx)) {
return;
}
- stack.push(new Token<>(ctx.getText().substring(1), String.class));
+ stack.push(new Token<>(ctx.getText().substring(1), String.class,
null));
--- End diff --
Seems unnecessary, it is implicit in the polymorphic constructor for
Token<T>. Or is this intended to be a clarification (although I don't see it)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
