Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/606#discussion_r120623722
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java
---
@@ -40,14 +40,22 @@
import static java.lang.String.format;
public class StellarCompiler extends StellarBaseListener {
- private static Token<?> EXPRESSION_REFERENCE = new Token<>(null,
Object.class);
- private static Token<?> LAMBDA_VARIABLES = new Token<>(null,
Object.class);
+ private static Token<?> EXPRESSION_REFERENCE = new Token<>(null,
Object.class, null);
+ private static Token<?> LAMBDA_VARIABLES = new Token<>(null,
Object.class, null);
private Expression expression;
private final ArithmeticEvaluator arithmeticEvaluator;
private final NumberLiteralEvaluator numberLiteralEvaluator;
private final ComparisonExpressionWithOperatorEvaluator
comparisonExpressionWithOperatorEvaluator;
+ public static class ShortCircuitFrame {}
+ public static class ShortCircuitOp {}
--- End diff --
We are actually instantiating them in this class. These are used to
indicate an instance of a short circuit frame on the stack. Unlike some of the
other marker classes, we actually want separate instances of these because you
could have nested frames.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
