Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146712573
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -174,21 +175,34 @@ protected SearchResponse search(SearchRequest
searchRequest, QueryBuilder queryB
@Override
public GroupResponse group(GroupRequest groupRequest) throws
InvalidSearchException {
- if(client == null) {
+ return group(groupRequest, new
QueryStringQueryBuilder(groupRequest.getQuery()));
+ }
+
+ /**
+ * Defers to a provided {@link
org.elasticsearch.index.query.QueryBuilder} for the query.
+ * @param groupRequest The request defining the parameters of the
grouping
+ * @param queryBuilder The actual query to be run. Intended for if the
SearchRequest requires wrapping
+ * @return The results of the query
+ * @throws InvalidSearchException When the query is malformed or the
current state doesn't allow search
+ */
--- End diff --
Thanks for the javadoc!
---
