[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

[justinleet]

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/911#discussion_r164836556
  
    --- Diff: 
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
 ---
    @@ -655,83 +699,54 @@ public void disabled_facet_query_returns_null_count() 
throws Exception {
       }
     
       @Test
    -  public void exceeding_max_resulsts_throws_exception() throws Exception {
    +  public void missing_type_facet_query() throws Exception {
    +    SearchRequest request = JSONUtils.INSTANCE.load(missingTypeFacetQuery, 
SearchRequest.class);
    +    SearchResponse response = dao.search(request);
    +    Assert.assertEquals(10, response.getTotal());
    +
    +    Map<String, Map<String, Long>> facetCounts = response.getFacetCounts();
    +    Assert.assertEquals(1, facetCounts.size());
    +    Map<String, Long> snortFieldCounts = facetCounts.get("snort_field");
    +    Assert.assertEquals(5, snortFieldCounts.size());
    +    Assert.assertEquals(new Long(1), snortFieldCounts.get("50"));
    --- End diff --
    
    any reason these aren't just 1L?


---