Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/911#discussion_r164838120
  
    --- Diff: 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrDao.java
 ---
    @@ -0,0 +1,118 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.solr.dao;
    +
    +import java.io.IOException;
    +import java.lang.invoke.MethodHandles;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Optional;
    +import org.apache.metron.indexing.dao.AccessConfig;
    +import org.apache.metron.indexing.dao.ColumnMetadataDao;
    +import org.apache.metron.indexing.dao.IndexDao;
    +import org.apache.metron.indexing.dao.search.FieldType;
    +import org.apache.metron.indexing.dao.search.GetRequest;
    +import org.apache.metron.indexing.dao.search.GroupRequest;
    +import org.apache.metron.indexing.dao.search.GroupResponse;
    +import org.apache.metron.indexing.dao.search.InvalidSearchException;
    +import org.apache.metron.indexing.dao.search.SearchRequest;
    +import org.apache.metron.indexing.dao.search.SearchResponse;
    +import org.apache.metron.indexing.dao.update.Document;
    +import org.apache.solr.client.solrj.SolrClient;
    +import org.apache.solr.client.solrj.impl.CloudSolrClient;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class SolrDao implements IndexDao {
    +
    +  private static final Logger LOG = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
    +  public static final String ID_FIELD = "guid";
    --- End diff --
    
    We already have GUID defined in Constants, we should use that.


---

Reply via email to