GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/920
METRON-1438 Move SHELL functions from metron-management to stellar-common
Part of making stellar more modular and stand alone is consolidation of
stellar functionality scattered through metron into stellar common. That
should be done if the functionality is generally useful and not metron
specific.
Where the functionality *is* metron specific, we should look to factor such
functionality as to extract generally useful functionality.
In the case of the SHELL- namespace, it is clearly not metron specific.
This pr moves this functionality from the metron-management module to
stellar common.
## Testing
- build and tests should run as normal
- shell functions such as those in the metron-management readme examples
should run
- functions should work as before
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [na] Have you written or updated unit tests and or integration tests to
verify your changes?
- [na] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [na] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron stellar-move-shell-funcs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #920
----
commit fe93fc40d94cc6148667eccc36853a2dc9925546
Author: Otto Fowler <ottobackwards@...>
Date: 2018-02-01T14:28:46Z
move ShellFunctions to stellar-common
commit 38775033240c7c174c99b10ffb5087c39b23672a
Author: Otto Fowler <ottobackwards@...>
Date: 2018-02-01T15:33:42Z
cleanup and refactor for failed tests where PausableInput did not unpause
commit 7af3d347567fe967c9c2ea1191c121a470d2bf34
Author: Otto Fowler <ottobackwards@...>
Date: 2018-02-01T18:28:43Z
fix readme
----
---
