Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/920#discussion_r165663581 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/ShellFunctionsTest.java --- @@ -40,8 +45,8 @@ ); Context context = new Context.Builder() - .with(Context.Capabilities.SHELL_VARIABLES , () -> variables) - .build(); + .with(Context.Capabilities.SHELL_VARIABLES , () -> variables).build(); --- End diff -- Right now, I never let my IDE reformat for me. Like you said, if we get the code base matching check style and I can load that style into my IDE, then I'd gladly let it do most of the work for me. Maybe I'll open a discuss thread. I don't know how to handle this kind of thing and it happens all the time. But for this specific scenario in your PR, it really doesn't matter either way. I think you're good to go either way.
---