For now, I think the easiest action for us to take here is to add a step to the pull request checklist asking contributors to run the e2e tests. In the future, we may want to look into moving to Cypress for e2e testing. One of the many advantages of Cypress is that it can be run by Travis <https://docs.cypress.io/guides/guides/continuous-integration.html#Travis>.
On Tue, Jul 3, 2018 at 11:13 AM Tibor Meller <tibor.mel...@gmail.com> wrote: > Hi All, > > Probably some of you already know that Shane and I working on stabilizing > and extending e2e tests in metron-interface/metron-alerts. > Currently, the tests using Protractor which is the default e2e testing > framework of Angular. > The tests injecting data right into ElasticSearch and making assertation on > the alerts UI. This means the tests only end to end from a UI perspective. > However, even with that, they are very useful in the validation of UI and > to prevent regressions. > > It the current state of the development it would be crucial to these tests > being run by every developer who making changes on the alerts UI code or in > the Metron REST service. > Without that, it is very hard to tell whether the tests are just flaky or > the changes brake some of them. > > So please start to experimentaling with this tool, and let us know how it > works out for you. > > You can find more information about setup and run on this link: > > https://github.com/tiborm/metron/blob/master/metron-interface/metron-alerts/README.md#e2e-tests > > Also if you have any opinion or idea on how to improve just let us know. > > Cheers, > Tibor >
