I'm not super keen on expanding the steps to contribute, especially in an avenue that should be automated. That being said, I think that until we get to the point of automating the e2e tests, it's sensible to add them to the checklist. So, I would support it, but I would also urge us to move forward the efforts of running these tests as part of the CI build.
What is the current gap there? Casey On Mon, Oct 1, 2018 at 7:41 AM Shane Ardell <shane.m.ard...@gmail.com> wrote: > Hello everyone, > > In another discussion thread from July, I briefly mentioned the idea of > adding a step to the pull request checklist asking contributors to run the > UI end-to-end tests. Since we aren't running e2e tests as part of the CI > build, it's easy for contributors to unintentionally break these tests. > Reminding contributors to run these tests will hopefully help catch > situations like this before opening a pull request. > > Does this make sense to everyone? > > Regards, > Shane >
