https://issues.apache.org/jira/browse/METRON-721
On February 15, 2017 at 06:28:24, Otto Fowler ([email protected]) wrote: https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/ On February 15, 2017 at 06:25:37, Otto Fowler ([email protected]) wrote: So, I had opportunity to throw a simple PR at Apache NiFi, and while doing that saw that they have a “checklist” template for their PR’s in Github. I was wondering if we might benefit from the same thing, esp. if it lined up with our dev guide? I do not know how you do it in github however. I could ask though. If we want to do this, I’ll create the jira and the template ——————————— Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0]( http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
