Github user mattf-horton commented on the issue:
https://github.com/apache/incubator-metron/pull/455
Hi @JonZeolla , thanks for taking a look amidst the other demands on your
time.
I disagree with 'mv $fullpath/site.xml.bak $fullpath/site.xml' for the
following reasons:
* site.xml is now a fully auto-generated file (like the contents of
site/markdown/), and is no longer tracked in git. That was the METRON-717
improvement. Thus, there is no reason to restore it.
* There are many other artifacts of bin/generate-md.sh besides site.xml,
that cannot be restored to former state, and that are likely to be just as
broken as site.xml if the build is interrupted. I don't want to give the
impression that we've restored a valid overall context.
* Leaving the entire state of the auto-generated content after an
interrupted build, including site.xml, may give valuable information about the
root cause of the break.
Please accept my not incorporating this change :-)
BTW, for Jon and all reviewers, I should mention that after this patch I
did a full re-validation of the site-book, both by:
* visual inspection in a browser of every page of the resulting book, and
by
* recursive diff of both the generated MD source files and resulting HTML
book files, before and after this whole PR patch.
No unexpected differences were found. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
