Github user mattf-horton commented on the issue:

    https://github.com/apache/incubator-metron/pull/455
  
    Hi @JonZeolla , @ottobackwards , @cestella , @mmiklavc ,
    Thanks to all of you for looking at this.  Taking issues in order:
    1. Absolutely right, no reason to have site.xml.bak any more!  Missed that, 
will fix momentarily.
    2. I'll have to look at that basename issue, but will fix and test on 
Centos.  Glad you noticed, and sorry about that.
    3. The weird behavior with site.xml and .gitignore is because the "git rm 
site.xml" command and the change to add "site.xml" to .gitignore, were squashed 
into a single commit.  If you do it as a sequence of two commits then it 
transpires cleanly.  But I was trying to respect the preference for squashing 
commits.  It won't manifest in fresh "git clone"s, but is a nuisance for folks 
pulling into an existing branch.
    
    Since I have to make another commit to fix #1 and #2, I will also split #3 
back into separate commits.  Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to