Duplicate syncronization in SocketAcceptor.startupWorker()
----------------------------------------------------------
Key: DIRMINA-409
URL: https://issues.apache.org/jira/browse/DIRMINA-409
Project: MINA
Issue Type: Bug
Components: Transport
Affects Versions: 1.1.1
Reporter: im-james
Priority: Trivial
Fix For: 1.1.2, 2.0.0-M1
In org.apache.mina.transport.socket.nio.SocketAcceptor, the method reads like
that:
private synchronized void startupWorker() throws IOException {
synchronized (lock) {
if (worker == null) {
selector = Selector.open();
worker = new Worker();
executor.execute(new NamePreservingRunnable(worker));
}
}
}
The 'synchronized' keyword of the method is, in my opinion, superfluous and
should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
