[
https://issues.apache.org/jira/browse/DIRMINA-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Trustin Lee resolved DIRMINA-409.
---------------------------------
Resolution: Fixed
Thanks for pointing it out. Fixed.
> Duplicate syncronization in SocketAcceptor.startupWorker()
> ----------------------------------------------------------
>
> Key: DIRMINA-409
> URL: https://issues.apache.org/jira/browse/DIRMINA-409
> Project: MINA
> Issue Type: Bug
> Components: Transport
> Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.0.4, 1.1.1
> Reporter: im-james
> Assignee: Trustin Lee
> Priority: Trivial
> Fix For: 1.0.5, 1.1.2
>
>
> In org.apache.mina.transport.socket.nio.SocketAcceptor, the method reads like
> that:
> private synchronized void startupWorker() throws IOException {
> synchronized (lock) {
> if (worker == null) {
> selector = Selector.open();
> worker = new Worker();
> executor.execute(new NamePreservingRunnable(worker));
> }
> }
> }
> The 'synchronized' keyword of the method is, in my opinion, superfluous and
> should be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
