Several questions on your KeepAliveFilter. 1) Why createActiveKeepAliveFilter, createPassiveKeepAliveFilter NOT return IoFilter(A factory method is better to return the interface instead of concrete class)? And my server or client has to extends ChainedIoHandler, otherwises, i can't use "config.getFilterChain().addFirst" in my original code. 2) A Client must use the createPassiveKeepAliveFilter?
On 10/16/07, mat <[EMAIL PROTECTED]> wrote: > > +1 very important (Definitely a MUST filter) > > On 9/27/07, Mark <[EMAIL PROTECTED]> wrote: > > > > [X]: +1, import > > > > On 9/26/07, Michael Grundvig <[EMAIL PROTECTED] > wrote: > > > > > > +1, import > > > > > > ----- Original Message ----- > > > From: "Trustin Lee" <[EMAIL PROTECTED]> > > > To: < dev@mina.apache.org> > > > Sent: Wednesday, September 26, 2007 5:24 PM > > > Subject: [VOTE] Import KeepAlive functionality contribution under MINA > > PMC > > > > > > > > > > Hi again. > > > > > > > > There's an important contribution from Eero Nevalainen that will > > help > > > > users to implement sending a protocol-specific keep-alive message > > > > periodically: > > > > > > > > https://issues.apache.org/jira/browse/DIRMINA-354 > > > > > > > > It's just a few classes, so I thought we could just import the code, > > > > but procedure is procedure. :) > > > > > > > > Software grant has been received long time ago, and also again, it > > was > > > > not processed on time due to my laziness. There's no reason not to > > > > import these classes IMO; it's just a few classes that makes > > people's > > > > life a lot easier. > > > > > > > > Once vote passes, I will start the paperwork and all the required > > > > procedure. > > > > > > > > [ ]: +1, import > > > > [ ] 0, abstain > > > > [ ]: -1, don't import > > > > > > > > Cheers, > > > > Trustin > > > > -- > > > > what we call human nature is actually human habit > > > > -- > > > > http://gleamynode.net/ > > > > -- > > > > PGP Key ID: 0x0255ECA6 > > > > > > > > > > > > -- > > ..Cheers > > Mark > > > >
