Yeah I believe so (as far as I can tell). It was more or less a straightforward porting, so there might be interesting and subtle behavior changes we may need to look at. But it should be a good solid baseline. Thanks, Sangjin
On Feb 4, 2008 2:50 PM, Mike Heath <[EMAIL PROTECTED]> wrote: > Rick McGuire wrote: > > I had some time this morning, and decided to take a look at this. It > > was fairly straightforward merging the changes back in to the 2.0 > > sandbox branch. > > There's a bit of a problem going on here with the jsps used for the > > tests. In the 1.1.5-based version, there was no eol-style property set > > for the jsps. This caused the strings that were returned by the tests > > to use \n for line terminators, which the unit tests expected to find in > > the message responses. In the 2.0 version, the eol-style is set to > > native, which causes the unit tests to fail when run on a Windows > > system. I was able to hack these up so they're now running cleanly, but > > I'm not terribly confident these won't end up breaking again in the > > future. I suspect a less encoding-specific approach is going to be > > needed for validating the responses should be used. > > > > Rick > > Rick, > > Does > http://svn.apache.org/repos/asf/geronimo/sandbox/async-http-client-mina2/ > contain all the bug fixes and latest features of AsyncHttpClient? Can > we use this to merge the changes over to the client under MINA? > > -Mike > > <snip> >
