On Sat, Jul 12, 2008 at 9:12 PM, peter royal <[EMAIL PROTECTED]> wrote:
> On Jul 7, 2008, at 2:30 PM, Niklas Gustavsson wrote:
>>
>>    @Override
>>    public void exceptionCaught(Throwable cause) {
>> -        if (log.isWarnEnabled()) {
>> +        if (cause instanceof Error) {
>> +            throw (Error) cause;
>> +        } else {
>>            log.warn("Unexpected exception.", cause);
>>        }
>
> +1

Applied.

$ svn -m "Making sure the DefaultExceptionMonitor does not catch and
swallow Errors, such as OOM" commit
src/main/java/org/apache/mina/core/DefaultExceptionMonitor.java
Sending        src/main/java/org/apache/mina/core/DefaultExceptionMonitor.java
Transmitting file data .
Committed revision 676293.

/niklas

Reply via email to