[ 
https://issues.apache.org/jira/browse/DIRMINA-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648705#action_12648705
 ] 

Edouard De Oliveira commented on DIRMINA-539:
---------------------------------------------

what about this one ?

boolean setTrafficClassIfAvailable(Socket socket) { 
  try { 
    int tc = socket.getTrafficClass(); 
    socket.setTrafficClass((~tc)&0x001E); 
    return (tc != socket.getTrafficClass()); 
  } catch (Exception e) { 
    return false; 
  } 
} 

does the job and informs the user if not done + no unnecessary tests like the 
previous one which would have lead to something like

if (isSetTrafficClassAvailable(mysocket)) {
  // set traffic class
 ....;
} 

> NioDatagramConnector doesn't takes the TrafficClass value set to his 
> DatagramSessionConfig 
> -------------------------------------------------------------------------------------------
>
>                 Key: DIRMINA-539
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-539
>             Project: MINA
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M1
>         Environment: WinXP, RHEL5 (probably not important)
>            Reporter: martin krivosik
>            Assignee: Emmanuel Lecharny
>             Fix For: 2.0.0-M4
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> client sending datagrams without taking care to the trafficClas set in the 
> config, so the ToS byte is not set in the packet sent from client.
> client code:
>   NioDatagramAcceptor acceptor = new NioDatagramAcceptor();
>   DatagramSessionConfig dcfg = 
> ((NioDatagramAcceptor)acceptor).getSessionConfig();
>   dcfg.setTrafficClass(tosByte);
>   InetSocketAddress bindAddrPort  = new InetSocketAddress(originatingIP, 
> port);
>   acceptor.bind(bindAddrPort);
> -> connecting to another computer with NioDatagramConnector.
> for me it looks like in the newHandle method of NioDatagramConnector is not 
> cared about TrafficClass (like it is done in NioDatagramAcceptor.open())
> The server part with the accceptor is OK and the correct ToS byte is set in 
> the packet.
> (the same problem may be in the socket, i have to check it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to