[ 
https://issues.apache.org/jira/browse/DIRMINA-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648934#action_12648934
 ] 

Emmanuel Lecharny commented on DIRMINA-539:
-------------------------------------------

The question is : do we really need this method in 2.0 (ie, 
isSetTrafficClassAvailable). The main problem is that we need an open socket in 
order to check that, and we have to set the traffic class, and reset it, to be 
sure that it's possible. As the Traffic Class is absolutely not guaranteed to 
be used by the underlying network layer, I think it's a lot of effort for a 
small improvement.

Now, this can be discussed. I understand that, from the user POV, masking all 
this complexity is good, but when a user tries to manipulate such advanced 
features, I think that it should be explicit.

> NioDatagramConnector doesn't takes the TrafficClass value set to his 
> DatagramSessionConfig 
> -------------------------------------------------------------------------------------------
>
>                 Key: DIRMINA-539
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-539
>             Project: MINA
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M1
>         Environment: WinXP, RHEL5 (probably not important)
>            Reporter: martin krivosik
>            Assignee: Emmanuel Lecharny
>             Fix For: 2.0.0-M4
>
>   Original Estimate: 0.33h
>  Remaining Estimate: 0.33h
>
> client sending datagrams without taking care to the trafficClas set in the 
> config, so the ToS byte is not set in the packet sent from client.
> client code:
>   NioDatagramAcceptor acceptor = new NioDatagramAcceptor();
>   DatagramSessionConfig dcfg = 
> ((NioDatagramAcceptor)acceptor).getSessionConfig();
>   dcfg.setTrafficClass(tosByte);
>   InetSocketAddress bindAddrPort  = new InetSocketAddress(originatingIP, 
> port);
>   acceptor.bind(bindAddrPort);
> -> connecting to another computer with NioDatagramConnector.
> for me it looks like in the newHandle method of NioDatagramConnector is not 
> cared about TrafficClass (like it is done in NioDatagramAcceptor.open())
> The server part with the accceptor is OK and the correct ToS byte is set in 
> the packet.
> (the same problem may be in the socket, i have to check it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to