I  had a look  and I'm inclined to think  that  the request is we
return the full pathname :-)


2009/6/1 Niklas Gustavsson (JIRA) <j...@apache.org>:
>
>    [ 
> https://issues.apache.org/jira/browse/FTPSERVER-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715024#action_12715024
>  ]
>
> Niklas Gustavsson commented on FTPSERVER-287:
> ---------------------------------------------
>
> I've worked some on this and wrote some test cases (I had some troubles 
> following along in the provided patch). Comparing with your examples above, 
> we seem to return the correct reply for whatever path I throw at it. However, 
> return only the file name, not the full path. The RFC says "The server        
>     will return a stream of names of files and no other information." which 
> seem like we might be doing the correct (or at least acceptable) thing when 
> returning only the file names.
>
> The test case has been added in trunk in 
> core/src/test/java/org/apache/ftpserver/clienttests/NLSTTest.java.
>
> I'm assuming I'm missing something so please help me along :-)
>
>> NLST: Implementation only supports listing files in working directory [patch 
>> provided]
>> --------------------------------------------------------------------------------------
>>
>>                 Key: FTPSERVER-287
>>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-287
>>             Project: FtpServer
>>          Issue Type: Bug
>>          Components: Core
>>    Affects Versions: 1.1
>>         Environment: Fedora 10-64bit and RH 5.2-64bit, Java 1.6.0_12-64
>>            Reporter: Dennis Keller
>>             Fix For: 1.0.2, 1.1
>>
>>         Attachments: nlst.patch
>>
>>
>> The NLST formatter, as implemented on trunk is insufficient to handle any 
>> request other than a file within in the current working directory. Some 
>> examples:
>> ftp> passive
>> Passive mode on.
>> ftp> nlist /directory/file.txt
>> 227 Entering Passive Mode (127,0,0,1,179,241)
>> 150 File status okay; about to open data connection.
>> file.txt
>> 226 Closing data connection.
>> Other FTP servers return the following:
>> ftp> passive
>> Passive mode on.
>> ftp> nlist /directory/file.txt
>> 227 Entering Passive Mode (127,0,0,1,179,241)
>> 150 File status okay; about to open data connection.
>> /directory/file.txt
>> 226 Closing data connection.
>> Upon investigating, I found that the formatter will not handle absolute file 
>> requests, parent directory request or non-absolute child directory requests. 
>> It does not error, it just doesn't give useful output.
>> I've modified the code to handle the cases that I could come up with, but 
>> there may be other situations that need to be covered. I'm not an expert on 
>> the FTP specification (but what I could find was not impressive), so there 
>> many be additional cases that need to be covered.
>> Please consider the attached patch, with accompanying test cases
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Reply via email to