On Mon, May 24, 2010 at 12:07 AM, Bogdan Ciprian Pistol <bogdancipr...@gmail.com> wrote: > I attached a patch on https://issues.apache.org/jira/browse/VYSPER-189
I've reviewed the patch, here are some general comments. * We should keep the BOSH code clean from the core module. I've added a new module for the BOSH work: https://svn.apache.org/repos/asf/mina/vysper/trunk/server/extensions/xep0124-xep0206-bosh * Could you please add new JIRA issues per feature you aim to implement. This makes it much easier to track the progress and also keeps the patches cleanly separated. The same approach was used for last years project: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310930&component=12312889&sorter/field=priority&sorter/order=DESC * The vysper_0.1.patch looks fine, committed into the new module (with updated package names) * The stuff in "scripts", is that all strophe.js? Perhaps we should stick that in an src/examples/resources directory (or similar)? * The stuff in "strophe.js" is guess is the code from the Wrox book where we're unsure about the license? /niklas
