Also the NOTICE files in the jars are wrong. For example, coap starts:
>> Apache MINA CoAP (constrained application protocol) 3.0.0-M1 << The leading blank line is wrong, and the version should not be appended. Ideally the jar Manifests should have some more info; have a look for example at any of the Commons jars. They have Implementation and Specification entries; easy to add in the parent pom. Also OSGI properties, but they are very complicated to get right so unless users ask for them, I'm not sure it's worth the hassle. On 18 July 2013 01:56, sebb <[email protected]> wrote: > On 18 July 2013 01:42, Emmanuel Lécharny <[email protected]> wrote: >> Le 7/18/13 2:39 AM, Emmanuel Lécharny a écrit : >>> Le 7/18/13 1:44 AM, sebb a écrit : >>> This is the third thing to fix for the next release. >> >> And the forth one is the Java 7 enforcer that need to be added. >> >> And the fifth one is the Benchmark module that have to be included into >> the source tarball. > > And the distribution module should be included. > >> I *think* we can blindly copy all the sources from the benchmarks[2] >> mdoules even if we don't provide the -Pbenchmarks profile. This could work. >> >> Thoughts ? > > I would expect the src assembly to copy just about all the source as > is to the source archive. > Because there are multiple modules, each of which can have target and > possibly other work directories I expect it will have to be done per > module. > But it's not difficult, just repetitive. > > I recommend that the RM always compares the content of SCM with the > source archive when checking a build... > At least some of the voters should do so too... > >> -- >> Regards, >> Cordialement, >> Emmanuel Lécharny >> www.iktek.com >>
